Reintroducing empty check for metric template references. #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erting removal in commit 7df1bee to support the optianl namespace. Adding test for future valdiation. Signed-off-by: Nick Freyaldenhoven <freyaldenhovennc@gmail.com>
Signed-off-by: Nick Freyaldenhoven <freyaldenhovennc@gmail.com>
Freydal
force-pushed
the
fix-optional-metric-template-namespace
branch
from
3a2590e
to
072d9b9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
- Coverage 54.69% 54.60% -0.09%
==========================================
Files 80 80
Lines 6823 6823
==========================================
- Hits 3732 3726 -6
- Misses 2511 2515 +4
- Partials 580 582 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting removal of empty string check in commit 7df1bee to support the namespace being optional. Adding test for future validation.